Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing polyfills, specifically, the one for Map from core-js #327

Open
ivan-aksamentov opened this issue Nov 26, 2019 · 0 comments

Comments

@ivan-aksamentov
Copy link

ivan-aksamentov commented Nov 26, 2019

I believe that libraries should not impose polyfils on their downstreams. Anyways, It is rarely needed in node libraries, and especially in test environments. Instead, it is user's responsibility to ensure that their runtime supports all the necessary features.

Consider removing this Map polyfill:

: require('core-js/library/es6/map'));

Map was mostly supported since Node 0.12 and is fully supported since Node 6. We are now on 12 LTS, so I think it is safe to remove this polyfill.

Along with it core-js dependency can be removed, along with the warning that it produces:

warning redux-saga-test-plan > [email protected]: core-js@<3.0 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

Thanks a lot for this great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant