You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.
Currently the code naively iterates over everything and does a ton of wasted processing. Moreover, it is getting more difficult to track which changes were made, when those changes were made, etc. It would be better to instead adopt an approach similar to the upgrade-needed handler in indexedDB where changes happen based on a version increment. We have the extension version readily available to us. It will require a version bump per settings schema change but maybe that is appropriate?
The text was updated successfully, but these errors were encountered:
jfroelich
changed the title
[config] removing/renaming legacy keys should involve a migration pattern
Changing legacy configuration keys should involve a migration pattern
Mar 28, 2019
Currently the code naively iterates over everything and does a ton of wasted processing. Moreover, it is getting more difficult to track which changes were made, when those changes were made, etc. It would be better to instead adopt an approach similar to the upgrade-needed handler in indexedDB where changes happen based on a version increment. We have the extension version readily available to us. It will require a version bump per settings schema change but maybe that is appropriate?
The text was updated successfully, but these errors were encountered: