Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Changing legacy configuration keys should involve a migration pattern #742

Open
jfroelich opened this issue Feb 16, 2019 · 0 comments
Open

Comments

@jfroelich
Copy link
Owner

Currently the code naively iterates over everything and does a ton of wasted processing. Moreover, it is getting more difficult to track which changes were made, when those changes were made, etc. It would be better to instead adopt an approach similar to the upgrade-needed handler in indexedDB where changes happen based on a version increment. We have the extension version readily available to us. It will require a version bump per settings schema change but maybe that is appropriate?

@jfroelich jfroelich self-assigned this Feb 16, 2019
@jfroelich jfroelich changed the title [config] removing/renaming legacy keys should involve a migration pattern Changing legacy configuration keys should involve a migration pattern Mar 28, 2019
@jfroelich jfroelich removed their assignment Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant