Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Split content filters into two steps: (1) annotate (2) prune #780

Open
jfroelich opened this issue Mar 16, 2019 · 1 comment
Open

Split content filters into two steps: (1) annotate (2) prune #780

jfroelich opened this issue Mar 16, 2019 · 1 comment
Labels
content filtering functionality related to content filtering

Comments

@jfroelich
Copy link
Owner

jfroelich commented Mar 16, 2019 •
edited
Loading

Instead of doing immediate removal during iteration, switch to annotation. This should lead to simpler debugging and testing with only a slight drop in performance.
@jfroelich jfroelich added the content filtering functionality related to content filtering label Mar 16, 2019
@jfroelich jfroelich self-assigned this Mar 16, 2019
@jfroelich jfroelich removed their assignment Apr 4, 2019
@jfroelich jfroelich changed the title Consider a mark and sweep approach in legible-text-filter Split content filters into two steps: annotation and filtering Apr 9, 2019
@jfroelich jfroelich changed the title Split content filters into two steps: annotation and filtering Split content filters into two steps: (1) annotate (2) prune Apr 11, 2019
@jfroelich
Copy link
Owner Author

But you cannot annotate HTML comments... so some filters would annotate and others would not. Which I guess is saying that some filters only have a prune step?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
content filtering functionality related to content filtering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfroelich