Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic when running build-docker-create command if image name does not include slash or colon #86

Open
rittneje opened this issue Mar 9, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@rittneje
Copy link

rittneje commented Mar 9, 2021

Describe the bug
A clear and concise description of what the bug is.

return path.Join(image.tag[indexOfFirstSlash:], "latest")

This line will panic if image.tag does not contain any slashes or colons.

To Reproduce
Steps to reproduce the behavior

Run the jfrog rt bdc command with an image file where the name doesn't include a slash.

Expected behavior
A clear and concise description of what you expected to happen.

It should give an error about the invalid input, but should not crash.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • JFrog CLI core version: 1.4.0
  • JFrog CLI version (if applicable): 1.45.0
  • Artifactory version: n/a

Additional context
Add any other context about the problem here.

@rittneje rittneje added the bug Something isn't working label Mar 9, 2021
@eyalbe4
Copy link
Contributor

eyalbe4 commented Mar 10, 2021

@rittneje,
Thanks for reporting this issue!
JFrog CLI 1.45.1 is released and include a fix.
We'd appreciate your feedback for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants