Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default regexVersionTag does not handle "v1.0.0-RC1" correctly on 2nd commit #179

Open
lbayle opened this issue Dec 3, 2023 · 0 comments

Comments

@lbayle
Copy link

lbayle commented Dec 3, 2023

version: 1.9.0

usage context:

  • [] maven command line: 3.9.6

Problem description:

the default regex has (?:-[a-zA-Z0-9\\-_]+)? inside the capture group. This is nice for RC.
But it works only on the commit that is tagged. on next commits, the RC has vanished !

UseCase:

git tag "1.2.0-RC1"
mvn validate
# ==> Building my-app 1.2.0-RC1-SNAPSHOT
touch foobar.txt && git add foobar.txt && git commit -m "add foobar"
mvn validate
# ==> Building my-app 1.2.0-SNAPSHOT

where is -RC1 ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant