Merge pull request #11990 from qmonmert/varinstead2

Sonar: Local-Variable Type Inference should be used

src/main/java/tech/jhipster/lite/shared/error/infrastructure/primary/ArgumentsReplacer.java

@@ -22,7 +22,7 @@ public static String replaceParameters(String message, Map<String, ?> arguments)
   }
 
   private String format(String message) {
-    StringBuilder result = new StringBuilder(message);
+    var result = new StringBuilder(message);
 
     int lastMustaches = result.indexOf(OPEN);
     while (lastMustaches != -1) {

src/main/java/tech/jhipster/lite/shared/error/infrastructure/primary/AssertionErrorsConfiguration.java

@@ -10,7 +10,7 @@ class AssertionErrorsConfiguration {
 
   @Bean("assertionErrorMessageSource")
   MessageSource assertionErrorMessageSource() {
-    ReloadableResourceBundleMessageSource source = new ReloadableResourceBundleMessageSource();
+    var source = new ReloadableResourceBundleMessageSource();
 
     source.setBasename("classpath:/messages/assertions-errors/assertion-errors-messages");
     source.setDefaultEncoding("UTF-8");

src/main/java/tech/jhipster/lite/shared/error/infrastructure/primary/GeneratorErrorsConfiguration.java

@@ -10,7 +10,7 @@ class GeneratorErrorsConfiguration {
 
   @Bean("generatorErrorMessageSource")
   MessageSource generatorErrorMessageSource() {
-    ReloadableResourceBundleMessageSource source = new ReloadableResourceBundleMessageSource();
+    var source = new ReloadableResourceBundleMessageSource();
 
     source.setBasename("classpath:/messages/errors/generator-errors-messages");
     source.setDefaultEncoding("UTF-8");

src/main/resources/generator/server/springboot/dbmigration/liquibase/main/AsyncSpringLiquibase.java.mustache

@@ -1,6 +1,5 @@
 package {{packageName}}.wire.liquibase.infrastructure.secondary;
 
-import java.sql.Connection;
 import java.sql.SQLException;
 import java.time.Duration;
 import java.util.concurrent.Executor;
@@ -56,7 +55,7 @@ class AsyncSpringLiquibase extends DataSourceClosingSpringLiquibase {
     if (env.acceptsProfiles(Profiles.of("local"))) {
       // Prevent Thread Lock with spring-cloud-context GenericScope
       // https://github.com/spring-cloud/spring-cloud-commons/commit/aaa7288bae3bb4d6fdbef1041691223238d77b7b#diff-afa0715eafc2b0154475fe672dab70e4R328
-      try (Connection connection = getDataSource().getConnection()) {
+      try (var connection = getDataSource().getConnection()) {
         executor.execute(() -> {
           try {
             logger.warn("Starting Liquibase asynchronously, your database might not be ready at startup!");
@@ -75,7 +74,7 @@ class AsyncSpringLiquibase extends DataSourceClosingSpringLiquibase {
   }
 
   protected void initDb() throws LiquibaseException {
-    StopWatch watch = new StopWatch();
+    var watch = new StopWatch();
     watch.start();
     super.afterPropertiesSet();
     watch.stop();

src/main/resources/generator/server/springboot/dbmigration/liquibase/test/SpringLiquibaseUtilTest.java.mustache

@@ -232,7 +232,7 @@ class SpringLiquibaseUtilTest {
     } catch (URISyntaxException exception) {
 {{/yamlSpringConfigurationFormat}}
 {{#propertiesSpringConfigurationFormat}}
-        Properties properties = new Properties();
+        var properties = new Properties();
         properties.load(
           SpringLiquibaseUtilTest.class.getClassLoader().getResourceAsStream("config/application-test.properties")
         );

src/main/resources/generator/server/springboot/mvc/internationalized-errors/main/ApplicationErrorsConfiguration.java.mustache

@@ -10,7 +10,7 @@ class {{ baseName }}ErrorsConfiguration {
 
   @Bean("applicationErrorMessageSource")
   MessageSource applicationErrorMessageSource() {
-    ReloadableResourceBundleMessageSource source = new ReloadableResourceBundleMessageSource();
+    var source = new ReloadableResourceBundleMessageSource();
 
     source.setBasename("classpath:/messages/errors/{{ baseFileName }}-errors-messages");
     source.setDefaultEncoding("UTF-8");

src/main/resources/generator/server/springboot/mvc/internationalized-errors/main/ArgumentsReplacer.java.mustache

@@ -22,7 +22,7 @@ final class ArgumentsReplacer {
   }
 
   private String format(String message) {
-    StringBuilder result = new StringBuilder(message);
+    var result = new StringBuilder(message);
 
     int lastMustaches = result.indexOf(OPEN);
     while (lastMustaches != -1) {

src/main/resources/generator/server/springboot/mvc/internationalized-errors/main/AssertionErrorsConfiguration.java.mustache

@@ -10,7 +10,7 @@ class AssertionErrorsConfiguration {
 
   @Bean("assertionErrorMessageSource")
   MessageSource assertionErrorMessageSource() {
-    ReloadableResourceBundleMessageSource source = new ReloadableResourceBundleMessageSource();
+    var source = new ReloadableResourceBundleMessageSource();
 
     source.setBasename("classpath:/messages/assertions-errors/assertion-errors-messages");
     source.setDefaultEncoding("UTF-8");

src/main/resources/generator/server/springboot/mvc/internationalized-errors/test/ApplicationErrorsMessagesTest.java.mustache

@@ -47,7 +47,7 @@ class {{ baseName }}ErrorsMessagesTest {
 
   private static Function<Path, Properties> toProperties() {
     return file -> {
-      Properties properties = new Properties();
+      var properties = new Properties();
       try {
         properties.load(Files.newInputStream(file));
       } catch (IOException e) {

src/main/resources/generator/server/springboot/mvc/internationalized-errors/test/AssertionErrorMessagesTest.java.mustache

@@ -32,7 +32,7 @@ class AssertionErrorMessagesTest {
 
   private static Function<Path, Properties> toProperties() {
     return file -> {
-      Properties properties = new Properties();
+      var properties = new Properties();
       try {
         properties.load(Files.newInputStream(file));
       } catch (IOException e) {

src/test/java/tech/jhipster/lite/generator/server/springboot/dbmigration/liquibase/domain/LiquibaseModuleFactoryTest.java

@@ -108,7 +108,7 @@ void shouldBuildModuleWithYamlSpringConfigurationFormat() {
       assertThatModuleWithFiles(module, pomFile(), logbackFile(), testLogbackFile())
         .hasFile("src/test/java/tech/jhipster/jhlitest/wire/liquibase/infrastructure/secondary/SpringLiquibaseUtilTest.java")
         .containing("YamlPropertiesFactoryBean yaml = new YamlPropertiesFactoryBean();")
-        .notContaining("Properties properties = new Properties();");
+        .notContaining("var properties = new Properties();");
     }
 
     @Test
@@ -122,7 +122,7 @@ void shouldBuildModuleWithPropertiesSpringConfigurationFormat() {
 
       assertThatModuleWithFiles(module, pomFile(), logbackFile(), testLogbackFile())
         .hasFile("src/test/java/tech/jhipster/jhlitest/wire/liquibase/infrastructure/secondary/SpringLiquibaseUtilTest.java")
-        .containing("Properties properties = new Properties();")
+        .containing("var properties = new Properties();")
         .notContaining("YamlPropertiesFactoryBean yaml = new YamlPropertiesFactoryBean();");
     }
   }

src/test/java/tech/jhipster/lite/shared/error/infrastructure/primary/AssertionErrorMessagesTest.java

@@ -30,7 +30,7 @@ private static Map<String, Properties> loadMessages() {
 
   private static Function<Path, Properties> toProperties() {
     return file -> {
-      Properties properties = new Properties();
+      var properties = new Properties();
       try {
         properties.load(Files.newInputStream(file));
       } catch (IOException e) {

src/test/java/tech/jhipster/lite/shared/error/infrastructure/primary/GeneratorErrorsMessagesTest.java

@@ -45,7 +45,7 @@ private static Map<String, Properties> loadMessages() {
 
   private static Function<Path, Properties> toProperties() {
     return file -> {
-      Properties properties = new Properties();
+      var properties = new Properties();
       try {
         properties.load(Files.newInputStream(file));
       } catch (IOException e) {