Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint 9 #10545

Merged
merged 1 commit into from
Aug 12, 2024
Merged

ESLint 9 #10545

merged 1 commit into from
Aug 12, 2024

Conversation

qmonmert
Copy link
Contributor

Fix #9476

@qmonmert qmonmert force-pushed the eslint9 branch 2 times, most recently from c48d410 to 6c893b9 Compare August 11, 2024 19:41
@qmonmert qmonmert marked this pull request as ready for review August 11, 2024 19:52
@qmonmert
Copy link
Contributor Author

@pascalgrimaud & @murdos if you have time, maybe be try locally 🙂

@murdos
Copy link
Contributor

murdos commented Aug 11, 2024

@pascalgrimaud & @murdos if you have time, maybe be try locally 🙂

I won't be able to test before one week, but good Idea 🙂

@pascalgrimaud
Copy link
Member

@qmonmert : are you confident enough to merge this?
Is it only for the engine, right?
What about the generated apps?

@qmonmert
Copy link
Contributor Author

@pascalgrimaud yes it's for the engine, I will do generated apps after (there is a ticket for that #9496 ), and I'm confident to merge and if there are some problems I'm ready to fix 🙂

@pascalgrimaud pascalgrimaud merged commit 614230e into jhipster:main Aug 12, 2024
34 checks passed
@qmonmert
Copy link
Contributor Author

@pascalgrimaud
Copy link
Member

@qmonmert : approved

@qmonmert
Copy link
Contributor Author

@pascalgrimaud thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration ESLint 9.0.0
3 participants