ensure selenium log folder is writable by its owner #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable. Could you add unit tests? |
|
I've never worked with unit tests before.. I'll see if I can find to read up on how to do that, and figure it out :) |
jhoblitt
pushed a commit
that referenced
this pull request
May 15, 2014
jhoblitt
pushed a commit
that referenced
this pull request
May 15, 2014
|
@KlavsKlavsen No worries. I added coverage in this commit, if your interested: a93d574 |
|
Thanks for the link - I hadn't found the time to look at it yet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our default mode is 0444 - which means selenium hub & node won't start.. because they can't write to log folder as user selenium.
I tested this fix, it works here.