Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setState should be called replaceState #126

Closed
jeroencoumans opened this issue Feb 12, 2015 · 1 comment
Closed

setState should be called replaceState #126

jeroencoumans opened this issue Feb 12, 2015 · 1 comment
Labels
enhancement v0.9

Comments

@jeroencoumans
Copy link
Contributor

Just got bitten by this; setState replaces the existing state object, while React's method merges the new state with existing state. If these methods are called the same as their React's counterparts, it makes sense to have the same behaviour :)
@jhollingworth jhollingworth mentioned this issue Feb 19, 2015
Merged
50 tasks
@jhollingworth
Copy link
Contributor

Implemented in v0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement v0.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeroencoumans @jhollingworth