Fetch api compatibility

[adamschoenemann]

Fetch does not work as expected in Chrome Canary, where fetch is a native implementation. My main issue was with the http source, in the getHeader function, there is a use of headers.map which appears to be non-standard, or at least not implemented in Chrome Canary nor original fetch polyfill (as far as I can see). Using the Headers.get() method instead should fix this issue

[jhollingworth]

hey, thanks for pointing this out. I will get a fix out asap

[adamschoenemann]

Thanks! 👍

[jhollingworth]

This is fixed in v0.9 which should be out soon

[vid]

I'm finding essential code which worked prior to the latest Canary now doesn't work. The problem seems to be it is consuming the body (bodyUsed: true) yet the value (res.json()) is still a promise after then() completes.

return this.post({ url: '/login', body: credentials }).then(function(res) {
  var v = res.json();
  console.log('P', res, 'v', v, res.body);
  // P {…bodyUsed: true } v Promise… undefined
  return LoginActions.loginResult(credentials, v);
});

Just wondering if you'll be releasing v0.9 very soon or if I should try to find a workaround. thanks!

[jhollingworth]

I can do a hotfix on the v0.8 branch if this is an issue

[vid]

If this is a known problem then that would be really helpful. My code only broke since updating Chrome.

[jhollingworth]

Hey, Marty v0.8.13 is out which has the fix for this bug.

[vid]

thanks for that. I haven't been able to fully test it due to another issue but on first glance it fixes the problem. one little issue is I had to manually install babel from the marty directory.

[jhollingworth]

Hmm, that shouldn't be needed. I think babelify leaked in from the v0.9 release. I will switch that back now.

Thanks

On 3 Mar 2015, at 7:18 pm, David H. Mason [email protected] wrote:

thanks for that. I haven't been able to fully test it due to another issue but on first glance it fixes the problem. one little issue is I had to manually install babel from the marty directory.

—
Reply to this email directly or view it on GitHub.

[jhollingworth]

This is fixed in v0.8.14

Thanks

[vid]

I had to manually install reactify as well. (=

[jhollingworth]

should be fixed now. Sorry about this

On 5 March 2015 at 17:20, David H. Mason [email protected] wrote:

I had to manually install reactify as well. (=

—
Reply to this email directly or view it on GitHub
#133 (comment).

http://twitter.com/jhollingworth | http://github.com/jhollingworth |
http://linkedin.com/in/jhollingworth | +44 7866 843 864