Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format 12 broken after last update #48

Closed
MCWertGaming opened this issue Oct 4, 2021 · 5 comments · Fixed by #49
Closed

clang-format 12 broken after last update #48

MCWertGaming opened this issue Oct 4, 2021 · 5 comments · Fixed by #49
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest

Comments

@MCWertGaming
Copy link
Contributor

The clang-format 12 version of the workflow is broken after the last update:

This is the console output of the workflow

Installing clang-format-12
Get:1 http://security.ubuntu.com/ubuntu impish-security InRelease [90.7 kB]
Get:2 http://archive.ubuntu.com/ubuntu impish InRelease [269 kB]
Get:3 http://archive.ubuntu.com/ubuntu impish-updates InRelease [90.7 kB]
Get:4 http://archive.ubuntu.com/ubuntu impish-backports InRelease [90.7 kB]
Get:5 http://archive.ubuntu.com/ubuntu impish/restricted amd64 Packages [119 kB]
Get:6 http://archive.ubuntu.com/ubuntu impish/main amd64 Packages [1809 kB]
Get:7 http://archive.ubuntu.com/ubuntu impish/universe amd64 Packages [16.7 MB]
Get:8 http://archive.ubuntu.com/ubuntu impish/multiverse amd64 Packages [255 kB]
Fetched 19.5 MB in 4s (5488 kB/s)
Reading package lists...
E: Problem executing scripts APT::Update::Post-Invoke 'rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true'
E: Sub-process returned an error code
/entrypoint.sh: line 22: /usr/bin/clang-format-12: No such file or directory
Failed on file: frontend/tools.hpp
@MCWertGaming
Copy link
Contributor Author

Same Problem with clang-format 13

Installing clang-format-13
Get:1 http://security.ubuntu.com/ubuntu impish-security InRelease [90.7 kB]
Get:2 http://archive.ubuntu.com/ubuntu impish InRelease [269 kB]
Get:3 http://archive.ubuntu.com/ubuntu impish-updates InRelease [90.7 kB]
Get:4 http://archive.ubuntu.com/ubuntu impish-backports InRelease [90.7 kB]
Get:5 http://archive.ubuntu.com/ubuntu impish/restricted amd64 Packages [119 kB]
Get:6 http://archive.ubuntu.com/ubuntu impish/main amd64 Packages [1809 kB]
Get:7 http://archive.ubuntu.com/ubuntu impish/multiverse amd64 Packages [255 kB]
Get:8 http://archive.ubuntu.com/ubuntu impish/universe amd64 Packages [16.7 MB]
Fetched 19.5 MB in 2s (8454 kB/s)
Reading package lists...
E: Problem executing scripts APT::Update::Post-Invoke 'rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true'
E: Sub-process returned an error code
/entrypoint.sh: line 22: /usr/bin/clang-format-13: No such file or directory
Failed on file: frontend/tools.hpp

My workflow configuration:

name: clang-format Check
on:
  push:
    branches: [ main ]
  pull_request:
    branches: [ main ]

jobs:
  formatting-check:
    name: Formatting Check
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Run clang-format in the frontends folder
      uses: jidicula/[email protected]
      with:
        clang-format-version: '13' # <- Tried both 12 and 13
        check-path: 'frontend'

@jidicula
Copy link
Owner

jidicula commented Oct 4, 2021

Thanks for filing this - I'll look into it further. In the meantime, are you still ok with using v4.0.0 of the workflow with clang-format-12?

@MCWertGaming
Copy link
Contributor Author

MCWertGaming commented Oct 4, 2021

Thank you really much for checking on this! It's no problem to stay on V4.0.0 as it's just the dependabot PR that is broken currently, we are all good!

@jidicula jidicula added bug Something isn't working Hacktoberfest good first issue Good for newcomers labels Oct 4, 2021
@MCWertGaming
Copy link
Contributor Author

Thanks for the quick fix!

@jidicula
Copy link
Owner

jidicula commented Oct 5, 2021

Thanks for the quick fix!

Thanks to @mjip 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants