Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.brightness() method does not affect brightness #1273

Closed
Gabilabrebi opened this issue Jan 26, 2024 · 1 comment · Fixed by #1312
Closed

.brightness() method does not affect brightness #1273

Gabilabrebi opened this issue Jan 26, 2024 · 1 comment · Fixed by #1312
Labels
bug there is a bug in the way jimp behaves released This issue/pull request has been released.

Comments

@Gabilabrebi
Copy link

Gabilabrebi commented Jan 26, 2024 •
edited
Loading

Expected Behavior

.brightness() method should affect brightness

Current Behavior

.brightness() method does not affect brightness but blend white with image everywhere

Failure Information (for bugs)

See above

Steps to Reproduce

  1. Use .brightness(0.9) on an .jpg image to go near full brightness
  2. Create image file with writeAsync()

Screenshots

  1. Brightness 0.9 in JIMP (nearly full brightness)
    near_full_brightness_jimp

  2. Brightness 4 in CSS (nearly full brightness)
    near_full_brightness_real

Context

No special conditions

  • Jimp Version: 0.22.10
  • Operating System: Windows
  • Node version: 21.5.0
@hipstersmoothie hipstersmoothie added the bug there is a bug in the way jimp behaves label Mar 28, 2024
@hipstersmoothie hipstersmoothie mentioned this issue Sep 2, 2024
Merged
@hipstersmoothie
Copy link
Collaborator

🚀 Issue was released in v1.1.2 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug there is a bug in the way jimp behaves released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make brightness function behave like other implementations jimp-dev/jimp
2 participants
@hipstersmoothie @Gabilabrebi