Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add start up probe and replace readiness probe with liveness probe #5470

Closed
girishc13 opened this issue Dec 1, 2022 · 1 comment · Fixed by #5407
Closed

feat: add start up probe and replace readiness probe with liveness probe #5470

girishc13 opened this issue Dec 1, 2022 · 1 comment · Fixed by #5407
Assignees
@girishc13

Comments

@girishc13
Copy link
Contributor

Describe the feature

Start up probe is better at handling the initial start up conditions of the application rather than increasing the initialDelaySeconds of the liveness or readiness probe.

Your proposal

The start up probe will use the jina ping command to report the first container ready status.

Environment

Screenshots
This was referenced Dec 1, 2022
Closed
Merged
@JoanFM
Copy link
Member

JoanFM commented Dec 1, 2022

Should we add livenessProbe also in this ticket?

@girishc13 girishc13 changed the title feat: add start up probe feat: add start up probe and replace readiness probe with liveness probe Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishc13 girishc13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add startupProbe and replace readiness probe with liveness probe jina-ai/serve
2 participants
@girishc13 @JoanFM