Global intrinsic functions like range not working in child template

[jpcima]

Hi, thanks for great work in the latest commits.
I find there remains an issue after applying the bugfixes.

In a child template, range-for appears non-working.
In the example, the first case is going to print Foo1,Foo2,Foo3,; but the same loop in an overriden block outputs nothing.

1.txt

{% block A %}
This is original block "A".
{% for i in range(3) %}Foo{{i+1}},{% endfor %}
{% endblock %}

2.txt

{% extends "1.txt" %}
{% block A %}
This is overriden block "A".
{% for i in range(3) %}Foo{{i+1}},{% endfor %}
{% endblock %}

[flexferrum]

Hm... You're right. I have to check this out. That's very strange behavior.

[flexferrum]

The problem is in visibility of the global intrinsic functions. If you replace range(3) with [1, 2, 3] in the second template all will work fine.

[jpcima]

Ok, about my personal globals which I insert using env.AddGlobal, these are recognized though.

[jpcima]

I find something at this call site of values.Clone().
When passing true to the function, range() is working.

Jinja2Cpp/src/statements.cpp

Line 268 in 6947605

RenderContext innerContext = values.Clone(m_isScoped);

[flexferrum]

BTW, globals should work with any value of this param. Because of globals. :)

[jpcima]

I'm a bit confused about understanding the vocabulary regarding the various scope rules.

I observe that the range global is set into intParams, or extValues/m_externalScope as it's known on RenderContext side.

When it's cloned, it doesn't pass to the clone context, it's only m_globalScope which does, externals are replaced with an empty scope.

Maybe it's intParams and extParams are swapped at TemplateImpl::Render?

[flexferrum]

No. I suppose, problem is here:

Jinja2Cpp/src/template_impl.h

Line 190 in 6947605

SetupGlobals(intParams);

Globals should set up in extParams rather than intParams.

[jpcima]

This small change fixes the problem on my side, and the test suite passes.