Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun with newer Ruby version #525

Open
d-krushinsky opened this issue Oct 16, 2024 · 6 comments
Open

Rerun with newer Ruby version #525

d-krushinsky opened this issue Oct 16, 2024 · 6 comments

Comments

@d-krushinsky
Copy link
Contributor

Looks like benchmark uses ruby 3.2.5, but now newer version (3.3.5) available in arch packages (https://archlinux.org/packages/?name=ruby)
with it ruby solution should work faster (smth like 1.1s-1.3s I think) and consume less memory (~25500k instead of ~37800k)
so it make sense to rerun benchmark with 3.3.5

@jinyus
Copy link
Owner

jinyus commented Oct 16, 2024

What's the indication that it was ran on 3.2.5? I build a fresh docker container everytime so it would've used the latest version in the repo. Nonetheless, I will run it again as I have a couple of compilers to update.

@d-krushinsky
Copy link
Contributor Author

d-krushinsky commented Oct 16, 2024

What's the indication that it was ran on 3.2.5?

When I ran #521 locally with 3.3.4 it was using less memory, but in yours comment it using more, so I decided to check what version you using. then I found that you using docker with arch and installs ruby via pacman. I checked https://archlinux.org/packages/?name=ruby and there was 3.2.5 in Extra and 3.3.5 in Extra-Testing (check my last comment in PR)
you updated results on 10th Oct, but 3.3.5 were moved to Extra repository only on 14th Oct

@jinyus
Copy link
Owner

jinyus commented Oct 16, 2024

Thanks for clarification, I will update it soon

@jinyus
Copy link
Owner

jinyus commented Oct 18, 2024

It's slower on the test machine. Ran the test 3 times on each with similar results.

ruby 3.2.5 (2024-07-26 revision 31d0f1a2e7):
| Ruby | 1.47 s | 23.07 s | 208.90 s | 233.44 s |

ruby 3.3.5 (2024-09-03 revision ef084cc8f4):
| Ruby | 1.56 s | 24.35 s | 227.20 s | 253.12 s |

@d-krushinsky
Copy link
Contributor Author

weird, looks like they change(mb broke) something in 3.3.5
tried to run locally: 3.3.4 is 0.3s faster than 3.3.5 🤔

3.3.4

Processing time (w/o IO): 1577ms
total: 1.71s memory: 25432k

3.3.5

Processing time (w/o IO): 1938ms
total: 2.04s memory: 34016k

@jinyus
Copy link
Owner

jinyus commented Oct 18, 2024

I'd suggest profiling it and report it upstream...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants