Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass only options.output to bundle.generate #60

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Pass only options.output to bundle.generate #60

merged 1 commit into from
Jan 16, 2020

Conversation

Lalem001
Copy link
Contributor

Based on the source of Rollup, I believe I have found a fix for #59 . I do not know if this should be considered a breaking change or not.

@Lalem001 Lalem001 changed the title Pass only output.options to bundle.generate Pass only options.output to bundle.generate Dec 11, 2019
@jlmakes jlmakes added the fix label Dec 12, 2019
@Lalem001
Copy link
Contributor Author

@jlmakes this PR has been sitting here for over a month. Any reason for the hesitance? Is it because I mentioned that it could be considered a breaking change?

@jlmakes jlmakes merged commit b5ef5c8 into jlmakes:master Jan 16, 2020
jlmakes added a commit that referenced this pull request Jan 17, 2020
@jlmakes
Release 7.0.3
6437d3d 
Closes #56
Closes #57
Closes #59
Closes #60
@Lalem001 Lalem001 deleted the fix-output-warnings branch January 17, 2020 03:58
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lalem001 @jlmakes