Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a distributed query failed when timeout #531

Closed
zhuoyuan-liu opened this issue Oct 11, 2024 · 3 comments
Closed

Make a distributed query failed when timeout #531

zhuoyuan-liu opened this issue Oct 11, 2024 · 3 comments
Assignees
Labels
✨ enhancement New feature or request osctrl-admin osctrl-admin related changes osctrl-tls osctrl-tls related changes queries On-demand queries related issues

Comments

@zhuoyuan-liu
Copy link
Contributor

Currently, when the nodes push new distributed query results back to osctrl, it checks if the query is completed. However, for some of the nodes, it may become inactive and would never send the results back, which would result in the distributed query in active forever.

I would suggest adding a timeout section for each distributed query, i.e. if the query is not completed within X time, we mark the distributed query as failed/inactive and remove the relevant records in DistributedQueryExecution table.

@javuto javuto self-assigned this Oct 11, 2024
@javuto javuto added ✨ enhancement New feature or request osctrl-tls osctrl-tls related changes osctrl-admin osctrl-admin related changes queries On-demand queries related issues labels Oct 11, 2024
@javuto
Copy link
Collaborator

javuto commented Oct 11, 2024

This is a good idea, do you think the timeout should be per environment or globally?

@zhuoyuan-liu
Copy link
Contributor Author

I think it would be great if we have some default values and accept different values for each distributed query. It would be great to combine with my another proposal. #529

@javuto
Copy link
Collaborator

javuto commented Oct 16, 2024

Landed #536 for osctrl-admin, now you can run queries and specify a timeout in hours, and also no expiration as well. This is set per query.

@javuto javuto closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request osctrl-admin osctrl-admin related changes osctrl-tls osctrl-tls related changes queries On-demand queries related issues
Projects
None yet
Development

No branches or pull requests

2 participants