Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to show images in the SLY's REPL? #629

Open
svetlyak40wt opened this issue Mar 14, 2024 · 8 comments
Open

How to show images in the SLY's REPL? #629

svetlyak40wt opened this issue Mar 14, 2024 · 8 comments

Comments

@svetlyak40wt
Copy link
Contributor

For SLIME there is a slime-media contrib with slime-media-insert-image which can be used like this: https://github.com/pszer/emacs-slime-image

But for SLY I can't find anything like that. Am I'm missing something?

@svetlyak40wt
Copy link
Contributor Author

@joaotavora what do you think?

@joaotavora
Copy link
Owner

I think it's a fine idea, but SLIME's contrib isn't immediately compatible, so you need to make something that plugs into sly-mrepl.el and sly-mrepl.lisp. I'd make a new contrib. You can make an in-tree contrib (under contribs/) or an out-of-tree one (using the sly-hello-world template).

Make this one as an in-source one, i.e. as a PR. That's because you will probably need to change bits of sly-mrepl.el and sly-mrepl.lisp. Good luck, I can't help you much. Maybe @aadcg can accompany you in this work.

@aadcg
Copy link
Collaborator

aadcg commented Apr 4, 2024

@joaotavora I think I could contribute some time to maintain SLY, since it seems clear that it's hard for you to be on top of everything.

Regarding this issue in particular, I'd be happy to review it, but I'm not keen on working on it.

Greetings @svetlyak40wt, hope you're doing well.

@joaotavora
Copy link
Owner

@aadcg yes. I'll send you an invitation. Be careful, last I heard project is used in production by many good friends :-) Shoot me a mail if in doubt about anything.

@joaotavora
Copy link
Owner

André, feel free to list yourself as current maintainer (or Co-Maintainer maybe) in the relevant source files and in appropriate forums.

@svetlyak40wt
Copy link
Contributor Author

Thank you guys! I'll try to implement this contrib some day!

@aadcg
Copy link
Collaborator

aadcg commented Apr 4, 2024

@joaotavora thanks! I'll add myself as a co-maintainer as soon as I have done some meaningful work. For the time being, I can't contribute much time but hopefully some.

I'll always ping you when in doubt, and maintain a rather conservative posture.

@jcguu95
Copy link

jcguu95 commented Apr 22, 2024

@svetlyak40wt Good news! I just implemented what you want :) Thanks for bringing up this request: #638

Please try it out and let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants