Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date parsing issues with dc:date #899

Closed
Porkepix opened this issue Feb 23, 2025 · 3 comments
Closed

Date parsing issues with dc:date #899

Porkepix opened this issue Feb 23, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@Porkepix
Copy link

Steps to Reproduce

For one feed I added to Capyreader, the date and time displayed is the one where the article got downloaded. The feed contain date and time for articles in this form: <dc:date>2025-02-21T16:00:00Z</dc:date>. This tag seems to be somehow expected as I've found places in the code with this specific tag, but maybe something in these dates create an issue and some difficulties to handle it (maybe the Z I'm not seeing in tests?)

Expected behavior

Correct handling of these date tags on that feed.

Screenshots or screen recording

No response

Device, Operating system, and app version

Capyreader 2025.02.1105, Android 14 on Motorola G84.

@Porkepix Porkepix added the bug Something isn't working label Feb 23, 2025
@jocmp
Copy link
Owner

jocmp commented Feb 23, 2025

Hey @Porkepix, thanks for bug report. Z offset should be handled by the "published" time parser. I added an extra test case to confirm: 9fce141. I also have a test feed that has a setup to parse dc:date (distrowatch HTML; distrowatch test case)

Can you share the feed URL? I can see if there's something specific that I'm missing. Feel free to send it over email to [email protected] if you want, too.

@jocmp jocmp moved this to Parking Lot in Capy Reader Feb 23, 2025
@jocmp
Copy link
Owner

jocmp commented Feb 23, 2025

Thanks for the feed URL @Porkepix. I took a look at the feed. I wasn't handling dc:date for RSS 2.0 feeds. I'll add a fix for this in the next update!

@jocmp jocmp moved this from Parking Lot to In Progress in Capy Reader Feb 23, 2025
@jocmp jocmp moved this from In Progress to Next Release in Capy Reader Feb 23, 2025
@jocmp jocmp changed the title Date parsing issues Date parsing issues with dc:date Feb 25, 2025
@jocmp
Copy link
Owner

jocmp commented Feb 27, 2025

This is now available in 2025.02.1111.

@jocmp jocmp closed this as completed Feb 27, 2025
@github-project-automation github-project-automation bot moved this from Next Release to Done in Capy Reader Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants