Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract interfaces for session types #250

Closed
joffrey-bion opened this issue May 13, 2023 · 0 comments
Closed

Extract interfaces for session types #250

joffrey-bion opened this issue May 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@joffrey-bion
Copy link
Owner

So far the session types ChromeBrowserSession and ChromePageSession were classes, which makes it more difficult to maintain regarding backwards compatiblity. By using interfaces instead and making classes internal, it's easier to keep a clean and lean public-facing API, and allows for further evolution.
@joffrey-bion joffrey-bion added breaking enhancement New feature or request and removed breaking labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion