chown resource executes every run, even when not changing anything

[miketheman]

We commonly see an execute resource updated every chef run, despite nothing being changed:
Example from our env:

- execute[chown -R root:root /mnt/consul] (consul::_service line 60)
- execute[chown -R root:root /etc/consul.d] (consul::_service line 60)
- execute[chown -R root:root /var/lib/consul] (consul::_service line 60)

This was introduced in #141 - current source.

A better approach is to guard the resource and execute only if necessary, something like:

execute "fixup consul #{dirname}" do
  command "chown -R #{consul_user}:#{consul_group} #{dirname}"
  only_if { Etc.getpwuid(File.stat(dirname).uid).name != "root" }
end

This is untested example code, based on conversations in mailing list and jira ticket tracker from 6 years ago, and the current conditional only applies to the uid, not gid. That should be an easy-enough fix.

Another method would be to use Ruby to get all subdirectories and create resources for each one, but that could lead to unexpected resource creation, if dirname has 10k subdirs - unlikely but possible.

I'd be happy to submit a PR for this, if you're interested in this approach.

/cc: @darron

[johnbellone]

This seems reasonable to me. Feel free to drop a PR and I'll cut another release prior to merging #126.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.