-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch over to using hooks instead of implementing deprecated TestListener #60
Comments
@localheinz Thank you for these details. Looks like we will need a new major release and core logic to support PHPUnit 9.0. That version is set for release in February 2020. Any chance you still have your implementation attempt? If so could you push it as a branch to your fork? I'm curious to see it and could offer some ideas. |
Instant upgrade path rectorphp/rector#1270
That's not related. Hooks are actually supported since PHPUnit 7.1. |
@johnkary what's the current state of this ticket? Is there anything we can help you with to get this fixed? |
Also interested in regaining this awesome feature. Anything we can do to facilitate progress? Does #83 need to be rebased? |
Quick update: for those of you coming here and looking for an alternative that works with
as well as
I just released |
To allow compatibility with
phpunit/phpunit:^9.0.0
, for which theTestListener
interface will have been removed, an implementation using hooks need to be developed.For reference, see
I took a stab at this earlier, but it appears there's a bit of a challenge as the hooks only receive the name of the test, rather than the
TestCase
. That is, from the name of the test the test class and test need to be derived in order to introspect its annotations for determining whether the test is configured for a different threshold then the basic setting inphpunit.xml
.The text was updated successfully, but these errors were encountered: