Fix for shadowJar out-of-date with configuration caching #708
Conversation
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| private List<Transformer> transformers; | |||
| private List<Relocator> relocators; | |||
| private transient List<Configuration> configurations; | |||
| private List<FileCollection> configurations; | |||
There was a problem hiding this comment.
I'm not sure whether the removal of transient can affect correctness of outputs; I was surprised that I didn't notice any differences in output between my first and second builds even though the second build was not UP-TO-DATE.
However, removing transient does seem to allow the task to be up-to-date in the second build.
cc @eskatos since it seems to have been added here: c9e30f1#diff-d5abeaae583093a8a92ef53ffe7f5a21cf185cf0d5e3a76edd236fa26dbf7e9fR34
There was a problem hiding this comment.
Good call! Looks good to me
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| private List<Transformer> transformers; | |||
| private List<Relocator> relocators; | |||
| private transient List<Configuration> configurations; | |||
| private List<FileCollection> configurations; | |||
There was a problem hiding this comment.
Good call! Looks good to me
|
It looks like I don't have permission to submit this or run checks against it; if anybody that does have permission would like to take a look that would be super cool |
|
Thanks! |
No description provided.