Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about missing max_cj_fee_rel/max_cj_fee_abs settings #135

Closed
theborakompanioni opened this issue Mar 1, 2022 · 0 comments · Fixed by #152
Closed

Add warning about missing max_cj_fee_rel/max_cj_fee_abs settings #135

theborakompanioni opened this issue Mar 1, 2022 · 0 comments · Fixed by #152
Assignees
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience

Comments

@theborakompanioni
Copy link
Collaborator

From @AdamISZ

i encountered a tricky error, but it's a function of me as user: i got 'error, config var not present' when starting the coinjoin. it took me a while to track down that it was because max_cj_fee_rel/abs was not present that caused it. users will have default joinmarket.cfgs at least to start with, so i hope they won't see that problem as they won't know how to fix it.

In the standalone versions of Jam the config variables max_cj_fee_rel and max_cj_fee_abs are populated (e.g. see Umbrel and Citadel). As these variables have no default values, users connecting to an existing jmwalletd instance will only ever see the message config var not present if they are missing. As a user I want a meaningful message about what is wrong or what I can do about it if manual adaptions are required.

Easiest workaround for that would be to always try to retrieve these values first.
It'd be also an option to set these variables according to user input, but these changes would not be persistent.
Assuming a user connects to an already running daemon, he or she is capable of adapting the config file as well.

@theborakompanioni theborakompanioni added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels Mar 1, 2022
@theborakompanioni theborakompanioni self-assigned this Mar 1, 2022
@ghost ghost closed this as completed in #152 Mar 7, 2022
@dergigi dergigi added this to JAM Mar 16, 2022
@dergigi dergigi moved this to Done ✅ in JAM Mar 16, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant