Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard be or fr dont work any more in the new version, solusition in new version ? #2663

Closed
theo500 opened this issue Jul 10, 2021 · 12 comments · Fixed by #5199
Closed

Keyboard be or fr dont work any more in the new version, solusition in new version ? #2663

theo500 opened this issue Jul 10, 2021 · 12 comments · Fixed by #5199

Comments

@theo500
Copy link

theo500 commented Jul 10, 2021

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Operating system
  • DOSBox-X release version or commit SHA1 this issue occurred on
  • Used configuration, e.g. dosbox-x.conf

Additional context
Add any other context about the problem here.

@Wengier
Copy link
Collaborator

Wengier commented Jul 11, 2021

I think you are probably using Windows SDL1 builds, and this may be related to issue #2572 because of changes for improving Japanese keyboard layouts. Can you try SDL2 builds instead and see if it fixes the problem? Thanks.

@theo500
Copy link
Author

theo500 commented Jul 11, 2021

Thanks, i reinstal dosbox-x and set sdl2. Now my keyboard is back azerty and not qwerty

@maron2000
Copy link
Contributor

Hi, can you try typing keyb be 850 or keyb fr 850?
Same kind of issue was solved here (#2637 (comment))
command_001

@Wengier
Copy link
Collaborator

Wengier commented Jul 16, 2021

@theo500 We are trying to solve the issue with SDL1 build too. Have you tried the step mentioned above? It is certainly desired to make them work in both SDL1 and SDL2 builds.

@maron2000
Copy link
Contributor

@Wengier @theo500
I was waiting for a reply whether the proposed workaround works, and meanwhile, I made a test version to fix SDL1 version to work without changing mapper setting.
Also, there were some issues in Linux build, so I amended some portion as well.
https://github.com/maron2000/dosbox-x-1/blob/linux_scancode/src/gui/sdl_mapper.cpp

The contents of fix is as below. (All regarding sdl_mapper.cpp)
I tested on Windows and Ubuntu 18.04.

Add scancode map for Linux (X11) sdl_mapper.cpp cfbc96d
GetKeyCode() Hardware scancode is prioritized when useScanCode option… 54b1ef5
Workaround for some of the keys return incorrect virtual keycodes d1e5754
Special handling of backslash keys (Linux SDL1 usescancodes=false) e639cd2

@Wengier
Copy link
Collaborator

Wengier commented Jul 19, 2021

@maron2000 Have you already stabilized the said fix? Thanks!

@maron2000
Copy link
Contributor

maron2000 commented Jul 19, 2021

@Wengier Well, as far as I tested with my JP keyboard, everything seems to be okay.
Before merging to your repository, would you please test mine? (Changes are only made for SDL1, usescancode=true)
The fix is based on your commit few days ago.
I confirmed that it can be built on Windows (VS2019) and Ubuntu 18.04 (gcc, g++).
I couldn't test MacOS but I think there should not be any problems.

https://github.com/maron2000/dosbox-x-1/tree/linux_scancode

@Wengier
Copy link
Collaborator

Wengier commented Jul 20, 2021

@maron2000 Sure, the changes need to be carefully tested before the next release, so that they work for international keyboards. The code will be merged to the DOSBox-X repository after some testing.

@Wengier
Copy link
Collaborator

Wengier commented Jul 25, 2021

The updated Windows SDL1 build containing the keyboard fix is available from:

Please check if how it works for you. Thanks!

@theo500
Copy link
Author

theo500 commented Jul 26, 2021

i downloaded the update.zip and tested it. My azerty keyboard now works perfectly

@maron2000
Copy link
Contributor

@Wengier
@theo500
Thanks for sharing the updated build.
Glad to hear that SDL1 versions works for AZERTY keyboards as well.

@maron2000
Copy link
Contributor

I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants