0.801 build failure on macOS 10.12 fatal error: 'remote-ext.h' file not found

[ilovezfs]

The error on macOS 10.12 Sierra is

clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o dbopl.o dbopl.cpp
clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o innova.o innova.cpp
clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o dongle.o dongle.cpp
In file included from ne2000.cpp:53:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/pcap.h:43:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/pcap/pcap.h:538:12: fatal error: 'remote-ext.h' file not found
  #include <remote-ext.h>
           ^
1 error generated.
make[3]: *** [ne2000.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [install-recursive] Error 1
make[1]: *** [install-recursive] Error 1
make: *** [install-recursive] Error 1

Full build log for 10.12 is here: https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/2595/version=sierra/consoleText

(Duplicate in case that gets deleted https://gist.githubusercontent.com/ilovezfs/b5646f9db2d7443e6cd1acce62ba5dd6/raw/179ea11a3ce91d475213ad6b22f845319886480c/gistfile1.txt)

Note that the build failure does not occur on OS X 10.10 or 10.11 https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/2595/

See Homebrew/homebrew-core#14319.

[joncampbell123]

That seems to be an issue with one of the SDL libraries. Nothing in DOSBox-X includes that header.

[JCount]

DOSBox-X sets #define HAVE_REMOTE on line 53 of ne2000.cpp, which in turn then triggers this code at pcap.h:538:

#ifdef HAVE_REMOTE
  /* Includes most of the public stuff that is needed for the remote capture */
  #include <remote-ext.h>
#endif	 /* HAVE_REMOTE */

which is what is directly producing the error.

The relevant libpcap code is here: libpcap-1.8.1/pcap/pcap.h#L529-L532, in the latest libpcap release.

[martinlindhe]

I think I fixed this issue in commit 45ce0bf

[ilovezfs]

any chance of getting a new tag?