Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move analysis code from HNN GUI to start hnn_core.analysis submodule #139

Closed
6 tasks
blakecaldwell opened this issue Aug 18, 2020 · 3 comments
Closed
6 tasks
Labels

Comments

@blakecaldwell
Copy link
Member

blakecaldwell commented Aug 18, 2020

Purpose:
To make code that was previously only in HNN GUI dual-purpose and serve for the analysis of simulations run by hnn-core from the command-line.

Rationale:
Since HNN GUI will import hnn-core already for hnn_core.simulator to run the NEURON solver, this will be a better home for the analysis functions. These functions will benefit from documentation and unit testing as part of hnn-core

Proposed components:

In addition to moving the code, the following improvments will be made:

  • Code cleanup (Use library functions, formatting, etc.)
  • Unit testing
  • Documentation
@blakecaldwell
Copy link
Member Author

It's not clear whether optimization code should go entirely in analysis, or the wrapper that runs code in hnn_core.simulator should also go in hnn_core.simulator.

@jasmainak
Copy link
Collaborator

@blakecaldwell can you cross-link to already open pull requests and issues? For e.g., for rmse we already have a pull request and also for LFP/CSD.

@ntolley
Copy link
Contributor

ntolley commented Jul 10, 2024

Going through the list all of these have actually been implemented in some capacity!

@ntolley ntolley closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants