From d7f5c37879947177858e3d9d54533b5ac396a92d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Damian=20Turczy=C5=84ski?= Date: Thu, 22 Sep 2016 14:44:11 +0100 Subject: [PATCH 1/2] Update README.md --- README.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index f05df83..ad3a5f0 100644 --- a/README.md +++ b/README.md @@ -11,16 +11,20 @@ c.GetApps() // returns a map[String]fargo.Application # Testing Tests can be executed using docker container. See the below section to build and start -all the required containers. Once fargo container is running: +all the required containers. Once eureka containers are running, and fargo container is built. -1. attach shell `docker attach fargo` -2. Checkout your test branch -3. execute `go test -v ./...` +Run: +``` +docker run --rm -v "$PWD":/go/src/github.com/hudl/fargo -w /go/src/github.com/hudl/fargo hudloss/fargo:master go test -v ./... +``` +Note: If you are running bash for windows add `MSYS_NO_PATHCONV=1 ` at the beggining The tests may need to be run a couple of times to allow changes to propagate between the two eureka servers. If the tests are failing, try running them again approximately 30 seconds later. +If you are adding new packages to godep you may want to update hudloss/fargo image first. + # Known Issues Until [this PR](https://github.com/mitchellh/vagrant/pull/2742) is in an From 9002c40b1dab03c6ff4112cbbbb4559e3968cc1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Damian=20Turczy=C5=84ski?= Date: Thu, 22 Sep 2016 14:55:34 +0100 Subject: [PATCH 2/2] Update README.md Typos fixing --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index ad3a5f0..130f966 100644 --- a/README.md +++ b/README.md @@ -11,19 +11,19 @@ c.GetApps() // returns a map[String]fargo.Application # Testing Tests can be executed using docker container. See the below section to build and start -all the required containers. Once eureka containers are running, and fargo container is built. +all the required containers. Once the Eureka containers are running, and fargo image is built then you can run the command as follows: Run: ``` docker run --rm -v "$PWD":/go/src/github.com/hudl/fargo -w /go/src/github.com/hudl/fargo hudloss/fargo:master go test -v ./... ``` -Note: If you are running bash for windows add `MSYS_NO_PATHCONV=1 ` at the beggining +Note: If you are running bash for Windows add `MSYS_NO_PATHCONV=1 ` at the beginning. The tests may need to be run a couple of times to allow changes to propagate -between the two eureka servers. If the tests are failing, try running them again +between the two Eureka servers. If the tests are failing, try running them again approximately 30 seconds later. -If you are adding new packages to godep you may want to update hudloss/fargo image first. +If you are adding new packages to godep you may want to update the `hudloss/fargo` image first. # Known Issues