New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for gists URLs #13

Open

kolarski opened this issue Mar 29, 2018 · 1 comment

Labels

request

kolarski commented Mar 29, 2018 •

edited

Loading

First, congrats for the great library.

As I was running trough a list of Github Urls, I stumbled upon a npm package: quarterto/cheerio-walk with the following Github URL:

git+https://gist.github.com/c4f67949eb47ea532dc27a6d8d93d274.git

I'm not sure if the URL is correct in the first place and if should be parsed like github url.
Currently the lib returns null for such urls.

jonschlinkert added the request label

Owner

jonschlinkert commented Mar 29, 2018

I think it makes sense to support gist URLs. A PR would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment