Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working and in code bags. #17

Open
korenevskiy opened this issue Jun 3, 2021 · 5 comments
Open

Not working and in code bags. #17

korenevskiy opened this issue Jun 3, 2021 · 5 comments

Comments

@korenevskiy
Copy link

korenevskiy commented Jun 3, 2021

@HLeithner @joomla-jenkins @mbabker @Hackwar

This is my first time using OAuth, I don't understand this protocol. But I see obvious errors in the code.
Probably the cat walked on the keyboard when they wrote this class. :-)

image

image

image

@korenevskiy
Copy link
Author

korenevskiy commented Jun 3, 2021

Please give a practical description of this library in README.md.
Sample code for how to use this class.
Please give an example code for easy use, without using inheritance. So that the developer can declare the object and set options for it.

@nibra nibra mentioned this issue Jun 3, 2021
@korenevskiy
Copy link
Author

@nibra
There are no examples of using this library on the Internet at all. Please write the simplest example in the document README.md.

@korenevskiy
Copy link
Author

korenevskiy commented Jun 3, 2021

@nibra
The code used the HttpFactory class before.
The code specifies the \Joomla\Http\HttpFactory namespace ;
But the CMS has the same HttpFactory class from the \Joomla\CMS\Http\HttpFactory namespace;
Maybe in the OAuth 2 HttpFactory from another space? Since there is just a static method.
The HttpFactory class has static methods in a different namespace.

@korenevskiy
Copy link
Author

@nibra
In the test assembly, you specified the arguments in the class __constructor()
$options = array(),
Compatibility with PHP 7.4 does not allow you to specify default values ahead of other arguments.

	public function __construct(
		$options = array(),
		Http $http,
		Input $input,
		AbstractWebApplication $application = null
	) {
		$this->options     = $options;
		$this->http        = $http;
		$this->input       = $input;
		$this->application = $application;
	}

@korenevskiy
Copy link
Author

@nibra This error fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant