Parse error: syntax error, unexpected '::' (T_PAAMAYIM_NEKUDOTAYIM) in plugins\system\languagefilter\languagefilter.php on line 630

[jsubri]

Steps to reproduce the issue

Staging (3.8.4-dev )with Multilingual Associations

Expected result

No error message

Actual result

Can't login, site broken

System information (as much as possible)

3.8.4-dev

Additional comments

modified line 630
from: $query = $this->app::getRouter()->parse($uri);
to: $query = $this->app->getRouter()->parse($uri);

[ghost]

Can't confirm. Login works as expected.

System information

3.8.4-dev
Multilanguage Site (4 Lang.) & Test English (GB) Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

• Apache-Server
• PHP 7.0.22
• MySQLi 5.6.35

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19267.}

[infograf768]

It's weird though...
@csthomas
please look. It comes from
#19099

[jsubri]

You need to have "System - Language Filter" enabled to reproduce the error

[csthomas]

Yes, older php has a problem with that. I start to work on PR

[joomdonation]

Honestly, I was scared when I saw #19099 merged. Haven't looked much as it but it seems it change existing behavior (you even need to change tests to have tests passed). There was also change in the to language filter plugin which seems not received code review yet, so to be safe, maybe it should go to 3.9.0 instead of to 3.8.4.

[csthomas]

Please test PR #19268

[csthomas]

The php code is not correctly parsed by php5:
$this->app::getRouter()->parse($uri);
so I changed it to:

$app = $this->app;
$app::getRouter()->parse($uri);

and now should be OK.

I tested:

<?php
        //Enter your code here, enjoy!

class O {
    public $a = null;
    
    function __construct($a) { $this->a = $a;}
    
    function printz() {
        //$this->a::getB()->printz(); // THIS IS NOT PARSED CORECTLY ON PHP 5
        $a = $this->a;
        $a::getB()->printz();
    }
}

class B {
    public function printz() { echo 'OK'; }
}

class A {
    public static function getB() { return new B(); }
}


$o = new O(new A());
$o->printz();

at http://sandbox.onlinephpfunctions.com/ on php 5.3 with success.

[brianteeman]

(nite that this error message is only untranslated in PHP <5.5

[csthomas]

Fix do not trigger the T_PAAMAYIM_NEKUDOTAYIM anymore on my php 5.6.26 however PR #19268 breaks (B/C) URLs like /index.php/fr/component/content/article/alias123?catid=13 that were working fine on 3.8.3 with modern routing.

@jsubri I moved it to this place.

The issue is that the link (without its own menu item) with removed IDs on the modern routing returns a 404 error is old and I have nothing to do with it yet:) At now it is only visible.

Yes, PR #19099 changed a way how build is a SEF link now. Early, it was hidden, joomla used Itemid from previous page or home page Itemid. Now everything is clearer.

If no menu assigned (to itself or parents) then /index.php/component/..., simple rule.

[csthomas]

If the biggest problem is that this generates 404 then I will add a fix for that.

Then mentioned link
/index.php/fr/component/content/article/alias123?catid=13 will be looking like
/index.php/fr/component/content/article/category13alias/alias123 or depending of the hierarchy
/index.php/fr/component/content/article/parent-category/category13alias/alias123

[csthomas]

I prepared a PR #19280 that fix issue with error 404 for links like /index.php/fr/component/content/article/alias123?catid=13

[joomla-cms-bot]

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19267

[Quy]

See PR #19280

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19267.}