-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jhelp] Glossary Joomla 4 #35416
Comments
Correct, that is why they are hidden and also mark as "DONOTTRANSLATE" |
@YGomiero I checked Joomla 3 translations as well. |
Seems we need a comment here? https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/language/en-GB/joomla.ini#L863 but isn't this true for all other JHELP entries too? |
The comment doesn't stop the auto-translation bit. |
and can we stop crowdin todo this? |
Yes, but that would mean an additional 4700 strings to translate. There are that much string in the CMS which have the same value. Another option is to Hide all duplicates with strict comparison. Which will not copy translations if the string constant and value are not the same as one in another file. Another option would be a language file for the JHELP and not have it in Crowdin, that will increase the Core with 1 file. |
looks as the last option would be the best |
Duplicate strings absolutely should not be translated automatically. If they were really duplicates we would have used a global. Just because the english for two strings is the same doesnt mean that it should be translated the same because the context is different.
That cannot be correct |
I fully agree, it's a change compared too what has been done for the last couple of years with Joomla v3. |
Reminder of a former discussion A specific file would do the job indeed. As for Crowdin, I have already told what I thought about this app... Keep it simple at least. Indeed take off the duplicate option. |
Ok, Looking at the facts.
My conclusion is that the "Auto-Translate Duplicates" option should be disabled at least in the new platform for Joomla 4. PS: Any objections? |
I agree with your conclusion and tbh surprised that auto-anything was ever turned on for a string I cant believe your figure of 4,700 though. |
Auto-translating actually works fine in most cases. Afaik we had it set in J3 to "autotranslate, but show", so translators were still able to translate it, in case it was different. In most of the cases however, duplicate strings are the same in all instances and thus it reduced work a lot. So I would not change that easily. As for the help strings, it may be interesting to know if they are actually still used. From what I remember they were used for supporting language specific help sites, provided by the translation teams. Nowadays we have all of them on our own Joomla property and it is translated there. So from my understanding we could as well hardcode the strings somehow without using language strings. But I may miss something here. |
@Bakual is correct, proofreaders can still change the translations if needed. A fast solution is splitting the file, which results in not providing the strings into the translations flow. |
I've started a PR to show how the strings could replaced by hardcoded keys. At least for most of the strings that would work easily. |
Closing as there is a PR, please test #35479 |
Joomla 4 :
Do not translate the line in the joomla.ini file
administrator/language/xx-XX/joomla.ini
JHELP_GLOSSARY="Glossary"
With the current version (J4.0.2), there is an error in the help section of Joomla 4 because the translation term is included in the url of jdoc, necessarily on a page that does not exist.
The problem also occurs on all translation packs.
line 35 : administrator\components\com_admin\tmpl\help\default.php
<?php echo HTMLHelper::_('link', Help::createUrl('JHELP_GLOSSARY'), Text::_('COM_ADMIN_GLOSSARY'), ['target' => 'helpFrame']); ?>
The text was updated successfully, but these errors were encountered: