Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Adapt Multilingual Sample Data as #43862 is merged #43989

Closed
fgsw opened this issue Aug 27, 2024 · 2 comments
Closed

[5.2] Adapt Multilingual Sample Data as #43862 is merged #43989

fgsw opened this issue Aug 27, 2024 · 2 comments

Comments

@fgsw
Copy link

fgsw commented Aug 27, 2024

Is your feature request related to a problem? Please describe.

Merged Pull Request #43862 removed restrictions for home language menu items. Multilingual Sample Data should adapt for 5.2-User.

Now after the installation Language home menu items are in separate menus:
Untitled

Describe the solution you'd like

Multilingual Sample Data for 5.2-User install Language home menu items in "Main Menu":
Untitled2

@brianteeman
Copy link
Contributor

I am not sure. Just because you can now put all the home menu items for each language in a single menu doesnt mean it is best practice to do that and the sample data should be showcasing best practice

@fgsw
Copy link
Author

fgsw commented Sep 7, 2024

the sample data should be showcasing best practice

@brianteeman good argument, thanks.

@fgsw fgsw closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants