Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Accessibility issues in pagebreak plugin #44429

Closed
drmenzelit opened this issue Nov 8, 2024 · 6 comments
Closed

[5.2] Accessibility issues in pagebreak plugin #44429

drmenzelit opened this issue Nov 8, 2024 · 6 comments
Labels

Comments

@drmenzelit
Copy link
Contributor

drmenzelit commented Nov 8, 2024

The issue is probably related with Bootstrap changes that were not adopted in the Joomla code

Steps to reproduce the issue

Create an article with some page breaks. Set the plugin to display as slider.
Use some accessibility tool like axe DevTools to check the site

Expected result

Correct code, no accessibility issues

Actual result

Accessibility issues
Image

Image

Image

System information (as much as possible)

Additional comments

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Nov 14, 2024

Just use <detail name="something"> for accordions: https://caniuse.com/mdn-html_elements_details_name
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#name

  • No JS needed
  • Pure HTML
  • Totally accessible

@Quy
Copy link
Contributor

Quy commented Nov 14, 2024

PR #40578?

@drmenzelit
Copy link
Contributor Author

@dgrammatiko do you want to rewrite the Pagebreak plugin and the used accordion function from Joomla?

@drmenzelit
Copy link
Contributor Author

@Quy thanks, I had totally forgotten that PR :-)

@dgrammatiko
Copy link
Contributor

I don't have the time to do so but should be straight forward with layouts/sublayouts

@drmenzelit
Copy link
Contributor Author

Closing as we already have a PR #40578

@HLeithner HLeithner added bug and removed bug labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants