exec command: Add support for window stack references (%1, %@, etc)
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's some possible area for conflict like if someone has an old command that does 'xdotool ... exec some command %1' and the user expected a literal "%1" to get passed as it has previously... but now xdotool will replace the %1 with a window id (or an error message). Other things needing improvement before merging:
|
jordansissel
changed the title
exec commandexec command: Add support for window stack references (%1, %@, etc)
command Window references will be replaced on the command-line in the same position that they occurred. In case of %@ (all windows), multiple arguments are inserted. For example, if the window list is two entries: 123, 456 `exec echo Hello %2` will run the command exactly as this list [echo, "Hello", "456"] `exec echo World %@` will run the command exactly as this list [echo, "World", "123", "456"] with each window id being a separate argument. For #431
jordansissel
force-pushed
the
issue/431
branch
from
2538512 to
7e37aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window references will be replaced on the command-line in the same position that they occurred. In case of %@ (all windows), multiple arguments are inserted.
For example, if the window list is two entries: 123, 456
exec echo Hello %2will run the command exactly as this list[echo, "Hello", "456"]
exec echo World %@will run the command exactly as this list[echo, "World", "123", "456"]
with each window id being a separate argument.
For #431