Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing fisher in fresh environment erases existing fish_plugins #775

Closed
evilhamsterman opened this issue Sep 1, 2023 · 3 comments
Closed

Comments

@evilhamsterman
Copy link

If you run the install command on a fresh instance but you already have a .config/fish/fish_plugins file, for example if you use a dotfiles repo, the install will empty the file leaving just jorgebucaran/fisher

Here's and example I ran in an Ubuntu container docker run --rm -it ubuntu /bin/bash so it's completely clean, all I did was install curl and fish then opened fish from bash

root@b40c530cf35a:~# fish
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
root@b40c530cf35a ~# ls -a
.  ..  .bashrc  .config  .local  .profile
root@b40c530cf35a ~# ls .config/fish
completions  conf.d  config.fish  fish_variables  functions
root@b40c530cf35a ~# echo "jorgebucaran/fisher
                     evilhamsterman/fish-sudo
                     evilhamsterman/fish-functions
                     ">.config/fish/fish_plugins
root@b40c530cf35a ~# cat .config/fish/fish_plugins
jorgebucaran/fisher
evilhamsterman/fish-sudo
evilhamsterman/fish-functions

root@b40c530cf35a ~# curl -sL https://raw.githubusercontent.com/jorgebucaran/fisher/main/functions/fisher.fish | source
&& fisher install jorgebucaran/fisher
fisher install version 4.4.4
Fetching https://api.github.com/repos/jorgebucaran/fisher/tarball/HEAD
Installing jorgebucaran/fisher
           /root/.config/fish/functions/fisher.fish
           /root/.config/fish/completions/fisher.fish
Installed 1 plugin/s
root@b40c530cf35a ~# cat .config/fish/fish_plugins
jorgebucaran/fisher
root@b40c530cf35a ~#
@jorgebucaran
Copy link
Owner

You're right, the issue seems to be specific to that bootstrapping scenario. The install command is doing exactly what it's designed for. If you've got a fish_plugins file in your new environment, you can simply bootstrap Fisher using:

curl -sL https://raw.githubusercontent.com/jorgebucaran/fisher/main/functions/fisher.fish | source && fisher update

This should get everything up to date.

@evilhamsterman
Copy link
Author

Sounds reasonable, probably help to update the docs to help poor schmucks like me 😁

@jorgebucaran
Copy link
Owner

Alright, we'll see about that! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants