Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call matrix_init_quantum from matrix_init() #6

Closed
okke-formsma opened this issue Jul 10, 2020 · 1 comment
Closed

Call matrix_init_quantum from matrix_init() #6

okke-formsma opened this issue Jul 10, 2020 · 1 comment
Labels
bug help wanted

Comments

@okke-formsma
Copy link

in https://github.com/joric/qmk/blob/nrf52-jorne/tmk_core/protocol/nrf/matrix.c#L184 matrix_init_user() is called instead of the normal call chain of matrix_init_quantum -> matrix_init_kb -> matrix_init_user.

This forces keyboards to use the matrix_init_user() method instead of matrix_init_kb, and robs users from configuring their own init funcs.

I'll make a pull request for this.
okke-formsma added a commit to okke-formsma/qmk_firmware that referenced this issue Jul 10, 2020
@okke-formsma
Call matrix_init_quantum from matrix_init instead of matrix_init_user
638693b 
Makes the behavior identical to non-NRF QMK.
Fixes joric#6
@okke-formsma okke-formsma mentioned this issue Jul 10, 2020
Merged
13 tasks
@joric
Copy link
Owner

joric commented Jul 12, 2020

merged

@joric joric closed this as completed Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okke-formsma @joric