Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/validate method #119

Merged
merged 10 commits into from
Jul 28, 2022
Merged

Feat/validate method #119

merged 10 commits into from
Jul 28, 2022

Conversation

josdejong
Copy link
Owner

Fixes #56: implements a validate() method, and passes contentErrors via the onChange callback.

This introduces a breaking change: the third argument of the onChange callback, the signature was:

onChange(content: Content, previousContent: Content, patchResult: JSONPatchResult | null)

and is now:

onChange(content: Content, previousContent: Content, changeStatus: { contentErrors: ContentErrors, patchResult: JSONPatchResult | null })

josdejong added 10 commits July 7, 2022 17:22
@josdejong
chore: refactor the ValidationError types
42acf6e
@josdejong
feat: implement method getValidationErrors (WIP)
c20c5b9
@josdejong
Merge branch 'main' into feat/validate_method
101d390 
# Conflicts:
#	src/lib/components/modes/textmode/TextMode.svelte
@josdejong
fix: replace setTimeout by updating validation results before returni…
1678227 
…ng them
@josdejong
chore: rename getValidationErrors to validate, and let it return …
1c1866c 
…a ContentErrors object
@josdejong
chore: don't use global variable in the validate function
060fd99
@josdejong
Merge branch 'main' into feat/validate_method
a38eed1 
# Conflicts:
#	src/lib/components/modes/textmode/TextMode.svelte
@josdejong
chore: refactor onChange callback to pass contentErrors too
12f36aa 
BREAKING CHANGES:

The signature of `onChange` is changed from `onChange(updatedContent, previousContent, patchResult)`
to `onChange(updatedContent, previousContent, { contentErrors, patchResult })`.
@josdejong
chore: add some debug statements
37e1ace
@josdejong
fix: memoize the validation results to prevent them from updated twice
31acb58
@josdejong josdejong merged commit 705f5f2 into main Jul 28, 2022
@josdejong josdejong deleted the feat/validate_method branch July 28, 2022 11:47
josdejong added a commit that referenced this pull request Jul 28, 2022
@josdejong
feat: implement validate method and pass contentErrors via onChange, f…
9847382 
…ixes #56 (#119)

BREAKING CHANGE:

The signature of `onChange` is changed from `onChange(updatedContent, previousContent, patchResult)`
to `onChange(updatedContent, previousContent, { contentErrors, patchResult })`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement an onValidation callback
1 participant
@josdejong