fix: replace debug with a util debug function
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to see if it is possible to use some environment variable of Svelte to detect whether running in development or production, and use that to enable/disable logging. It would be cool to see if we can utilize dead code elimination of all the debug lines when in production. |
|
lgtm : )
can we micro optimize this later? ; ) |
|
Thanks.
😂 yes. This new solution already has much less lines of code, so it's already an improvement anyway. |
|
Published now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@milahu can you have a look at this PR?
For reference: #33, #31.