Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event color not working #23

Open
LBianchi98 opened this issue Sep 14, 2018 · 7 comments
Open

Event color not working #23

LBianchi98 opened this issue Sep 14, 2018 · 7 comments

Comments

@LBianchi98
Copy link

Maybe it should be my mistake but i'm trying to change some events' color but it remains the same.

@RetroSGJacobs
Copy link
Contributor

Could possibly be due to #17. Try setting the version in your package.json to point to "git+https://github.com/joshjhargreaves/react-native-event-calendar.git", I think that should work?

@BobsonTheFirst
Copy link

I encounter the same problem, the event color won't change. I changed the version in my package.json, but it doesn't work (see below). Any other suggestions?

"repository": {
"type": "git",
"url": "git+https://github.com/joshjhargreaves/react-native-event-calendar.git"
},

@RetroSGJacobs
Copy link
Contributor

Hmm, have you perhaps tried adding the dependency like this?

"dependencies": {
    "react-native-events-calendar": "git+https://github.com/joshjhargreaves/react-native-event-calendar.git",
}

If this doesn't work, feel free to try my own fork "git+https://github.com/RetroSGJacobs/react-native-event-calendar.git", although I haven't quite kept track of the new changes since my PR. I hope this helps!

@BobsonTheFirst
Copy link

Hi, thanks for your fast reply.

Unfortunately your both suggestions aren't working. I added the dependencies and used your fork. So I am afraid I am doing something wrong?

@RetroSGJacobs
Copy link
Contributor

Perhaps try to manually delete the react-native-event-calendar npm package and perform an npm / yarn install? Normally if making such a change it is necessary to do so, assuming you haven't already tried this.

@BobsonTheFirst
Copy link

I started a clean new project to see if maybe something was wrong inside my project. After following your instructions, it worked. So indeed, adding/changing the following in the package.json file helped:

"dependencies": {
"react": "16.6.3",
"react-native": "0.57.8",
"react-native-events-calendar": "git+https://github.com/joshjhargreaves/react-native-event-calendar.git"
},
"repository": {
"type": "git",
"url": "git+https://github.com/joshjhargreaves/react-native-event-calendar.git"
}

Now i have to figure out how to fix the colors in my own project. Thanks!

@RetroSGJacobs
Copy link
Contributor

Awesome, glad to hear you got it sorted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants