Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double session names after 2.0 #151

Closed
2 tasks done
karamanliev opened this issue Aug 26, 2024 · 4 comments
Closed
2 tasks done

Double session names after 2.0 #151

karamanliev opened this issue Aug 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@karamanliev
Copy link

karamanliev commented Aug 26, 2024

What happened?

After updating to 2.0.2, when opening a session its name gets cloned - once for the opened session, which is correct, but it stays also as a inactive session:

image

image

On my laptop I'm still on 1.2.0 and the behavior is not the same.

image

Version

2.0.2

Relevant log output

There are no error messages.

Reviewed

  • Reviewed existing issues and made sure this bug has not already been submitted.
  • I have read the documentation and understand how sesh works before submitting this bug
@karamanliev karamanliev added the bug Something isn't working label Aug 26, 2024
@joshmedeski
Copy link
Owner

Good call @karamanliev! I reported them.

@joshmedeski
Copy link
Owner

@karamanliev

Some users want to use the same path for different session configurations (see #124).

Overall, it was easier in the rewrite to simplify the logic and now have the different sources communicate with each other to generate a list.

I'd be willing to add an opt-in feature similar to this back in, but it will require a bit of thought for dealing with edge-cases.

@karamanliev
Copy link
Author

Gotcha, I understand the use case, but an opt-in/out would be awesome.

Thanks for the great software!

@joshmedeski joshmedeski moved this from In Progress to Next in OSS Development Aug 26, 2024
Repository owner deleted a comment from karamanliev Aug 27, 2024
@joshmedeski
Copy link
Owner

Created #156 for this to be done.

@github-project-automation github-project-automation bot moved this from Next to Done in OSS Development Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants
@joshmedeski @karamanliev and others