-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looped sounds can't be addressed after completing their first loop #26
Comments
Howler's onend Function fires when the sound finishes playing (if it is looping, it'll fire at the end of each loop). The first parameter is the ID of the sound. |
Any feasible workarounds for this? Being unable to stop sounds makes this library not applicable for background music. |
I've applied a git patch to to fix it in my local repo. Simply comment out _this2.removeId(id); and this.removeId(id); in relevant spots in howler_integration.js and it seems to do the trick. |
@rovenko Thanks for the heads up! I got it fixed and added a pull request that supports looped sounds. |
Merged #28. I'll release the fix in a few days, thank you both for the bug report and PR, I really appreciate the help! |
3.3.0 Published to npm! |
When using a looped sound, it's only possible to address the sound (i.e. fade / stop) only when the very first iteration of the loop is being played back.
As soon as the sound goes into the second iteration of the loop, the same control actions stop working.
The text was updated successfully, but these errors were encountered: