New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minTopValue not working #157

Open

bobbyflowstate opened this issue May 2, 2019 · 1 comment

bobbyflowstate commented May 2, 2019

Hi there,
Thanks for making this great library. It's works mostly, but I'm not able to get minTopValue to work.

As stated in the README:

so if at least 100px are in viewport, we mark element as visible.

I've set minTopValue to just 10, but the element goes hidden as soon as 1 pixel goes outside the containment.

I've even tried it in the codesandbox and it doesn't work: https://codesandbox.io/s/jl8r92z0lv

Anyway I can achieve this? I basically only want an element to update as hidden if half of it is outside the containment.

Thanks!

antoine-ga commented May 23, 2019 •

edited

Loading

A bit late but I think you have to add partialVisibility={true} if you want to play with minTopValue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment