Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MapLibre Android 11.7.+, jnigen/jni 0.13.0 #181

Closed
wants to merge 3 commits into from

Conversation

josxha
Copy link
Owner

@josxha josxha commented Dec 17, 2024

superseeds #181

Todo

  • OfflineManager jni bindings
  • jnigen errors

Steps to update jni bindings

  • toggle // JNIGEN lines
  • download new arb file: https://repo1.maven.org/maven2/org/maplibre/gl/android-sdk/11.7.0/android-sdk-11.7.0.aar and place in /example/android/MapLibreAndroid
  • update used version in /example/android/MapLibreAndroid/build.gradle
  • remove every jni related code and replace it with stubs 😑
  • run flutter build apk from the example directory
  • run dart run jnigen --config jnigen.yml
  • revert changes made for stubs
  • update android implementation according to the new generated jni code

@josxha josxha added this to the v0.2.0 milestone Dec 17, 2024
@josxha josxha enabled auto-merge (squash) December 17, 2024 09:26
Copy link

cloudflare-workers-and-pages bot commented Dec 17, 2024

Deploying flutter-maplibre with  Cloudflare Pages  Cloudflare Pages

Latest commit: 60ef3e2
Status: ✅  Deploy successful!
Preview URL: https://ffdcf4f7.flutter-maplibre.pages.dev
Branch Preview URL: https://maplibre-android-11-7.flutter-maplibre.pages.dev

View logs

@josxha josxha changed the title feat: MapLibre Android 11.7.+ feat: MapLibre Android 11.7.+, jnigen/jni 0.13.0 Dec 17, 2024
@josxha josxha marked this pull request as draft December 17, 2024 11:42
auto-merge was automatically disabled December 17, 2024 11:42

Pull request was converted to draft

@josxha
Copy link
Owner Author

josxha commented Dec 17, 2024

jnigen 0.13.0 seems to have some errors. Let's split the pr up.

@josxha josxha closed this Dec 17, 2024
@josxha josxha deleted the maplibre-android-11.7.+ branch December 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant