Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Missing genders #654

Closed
jbrecht opened this issue Apr 2, 2019 · 3 comments
Closed

Missing genders #654

jbrecht opened this issue Apr 2, 2019 · 3 comments
Labels

Comments

@jbrecht
Copy link

jbrecht commented Apr 2, 2019

Apologies if this is a misunderstanding, but I'm curious why, for example, 'woman astronaut' has a null gender in emoji.json? Upon inspection, it looks like perhaps gender is only given a value if the unicode for it includes the 'woman symbol' emoji (2640), but not if it includes the 'woman' emoji (1f469). (Presumably this also applies for the male equivalents.)

Shouldn't the gender value of 'woman astronaut' be '1f469' rather than null? Or is that a different category, apart from gender?

@caseyahenson
Copy link
Contributor

@jbrecht this is a great catch, thank you for pointing it out. It does appear that the gender for codepoints without 2640 are not being correctly set in the emoji.json file. Woman Astronaut should have a gender value of 2640 (the base code point of the female sign). We'll make the adjustments and get this published as soon as possible.

@jbrecht
Copy link
Author

jbrecht commented Apr 18, 2019

Thanks @caseyahenson !

@caseyahenson
Copy link
Contributor

This is fixed in the 5.0 release https://github.com/joypixels/emoji-toolkit/releases/tag/5.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants