Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

theme-related data attributes are not respected #2713

Closed
matthewleon opened this issue Oct 15, 2011 · 4 comments
Closed

theme-related data attributes are not respected #2713

matthewleon opened this issue Oct 15, 2011 · 4 comments

Comments

@matthewleon
Copy link

Several pages of documentation (ie http://jquerymobile.com/demos/1.0rc1/docs/buttons/buttons-options.html) describe data attributes on form elements, such as data-shadow, that should impact theming. These attributes are currently ignored.

@matthewleon
Copy link
Author

Relevant pull request is here: #2714

@matthewleon
Copy link
Author

Now that I've done this for buttons, I feel like all form elements should have these options. If someone gives me the go-ahead, I'll happily write the relevant code.

@toddparker
Copy link
Contributor

I think this is a good idea, but I might ask to wait until we ship 1.0 to look at this. The buttons were broken so those needed to be fixed up, but these other form elements would be additions to the scope and API so I'd like to think about this a bit more.

@toddparker
Copy link
Contributor

Would you mind adding this to the feature request wiki page, then close the issue. If you don't hear back from us a month or so from now, ping this ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants