This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Continue to call pageLoading when autoInitialize is false. #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge/pages on dom ready using $.mobile.autoInitialize.
Conflicts: js/jquery.mobile.core.js
* 'master' of https://github.com/jquery/jquery-mobile: added a workaround for the selectmenu plugin's nativeMenu in Opera. Opera browsers improperly support opacity on select elements, either hiding the menu button but not its text (in Mini), or hiding the text but not the button. Either way, it makes our hidden-select trick look really bad, or unusable. This workaround adds a class to the select in Opera, and makes the native menu visible. In the case of a false positive, that's not a bad outcome. Fixes #897
…ody instead of pageContainer. added internal dom-ready for initializePage.
|
toreym, Once you've figured out the changes you want if your can rebase your master, create a new branch, cherry pick the commits made after those two big merges and resubmit that would be huge. Merging and commit review on clean commits is much easier. Thanks for working with us on this. |
…avor of html5 range step attribute
…g of the overall row button div in the LI. It seems this may be due to the event handlers bound to the div button, but I'm not entirely sure that's it. Either way, this workaround is straightforward and does not introduce issues in other browsers, so aside from the additional overhead involved in re-appending the links to the LIs, this fix is good to go. Fixes #874
…sed on search inputs to ui-icon-searchinput
…put so I modified the script for search input to reflect this change
…ar button on search inputs accordingly.
… This moves the values into CSS with values that are aimed towards iPhone (as this is addressing an iPhone transitions issue with the address bar show/hide).
…toggling on and off on every click. Fixes #935 as well.
…ge/pages on dom ready using $.mobile.autoInitialize.
…ody instead of pageContainer. added internal dom-ready for initializePage.
* 'master' of https://github.com/jquery/jquery-mobile: (34 commits) Make some tweaks to the deploy script. Tagging the 1.0a3 release. Added bg color for demo pages home button fixes fixed a regression in some android 2.2 devices where checkboxes were toggling on and off on every click. Fixes #935 as well. typo in code example. Fixes #966 Device image Added a home link to all pages and changed the header bar theme swatch to b globally Page min-height was being calculated with JS and it was far too tall. This moves the values into CSS with values that are aimed towards iPhone (as this is addressing an iPhone transitions issue with the address bar show/hide). Upgraded YUI Compressor to 2.4.4. Removed experimental section with API browser because it's outdated Updated sample page templates and docs to mobile a3 and jquery 1.5 Added 1px extra padding to icon only buttons. Adjusted offset for clear button on search inputs accordingly. Icon source PSD New high-res logo with better compression Alpha 3 flag Updated Valencia with new icons Created demo buttons for the new home and search icons Re-named the ui-icon-search used on search inputs to ui-icon-searchinput so I modified the script for search input to reflect this change Added new home and search icon classes. Re-named the ui-icon-search used on search inputs to ui-icon-searchinput ...
|
johnbender, I just sent another pull request #969 which is a rebase and changes on a new branch. Hopefully that will make things easier. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a call to pageLoading when autoInitialize is false.