Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-text search #463

Closed
shaobozi opened this issue Feb 10, 2017 · 13 comments
Closed

Full-text search #463

shaobozi opened this issue Feb 10, 2017 · 13 comments
Labels
enhancement New feature or request 📌 This can't go stale
Milestone

Comments

@shaobozi
Copy link

No description provided.

@shaobozi shaobozi changed the title It will be better if we have can search entry with key words. It will be better if we have can search entries with key words. Feb 10, 2017
@maebert maebert added the needs more info Further information is requested label Feb 10, 2017
@maebert
Copy link
Contributor

maebert commented Feb 10, 2017

Hey Shabozi, can you maybe give an example of what you mean?

@shaobozi
Copy link
Author

like the command >: jrnl -s "blah" ; will list all entries with the word "blah" .

@maebert maebert changed the title It will be better if we have can search entries with key words. Full-text search Feb 15, 2017
@maebert maebert added this to the 2.2 - Search milestone Feb 15, 2017
@maebert
Copy link
Contributor

maebert commented Feb 15, 2017

Ah, now I understand.This'll come in the next big release, see also #313.

@radomirbosak
Copy link
Contributor

I rebased my earlier PR which solves this: #470

@shaobozi Note that -s is already used for turning on short output (--short).

@maebert , do you plan to postpone any search-related features until 2.2 ? What is the current schedule for adding new features?

@craftyguy
Copy link

craftyguy commented Dec 17, 2017

Is this feature still planned? Being able to search for any text in a journal would be super helpful, and it would save me from having to tag every word :P

@empireshades
Copy link

Ah, now I understand.This'll come in the next big release, see also #313.

Is this feature still slated for release? Been almost 2 years.

@wren wren removed this from the 2.2 - Search milestone Jul 7, 2019
@wren wren added enhancement New feature or request and removed needs more info Further information is requested labels Jul 20, 2019
@wren
Copy link
Member

wren commented Jul 20, 2019

Yup, this is a good idea for a feature. We'll (re)schedule it for a milestone once we get the rest of the project organized.

PRs welcome!

@stale
Copy link

stale bot commented Sep 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive issue: will be closed soon if no activity label Sep 18, 2019
@wren wren added this to the v2.4 - The Search for Spock milestone Sep 21, 2019
@stale stale bot removed the stale Inactive issue: will be closed soon if no activity label Sep 21, 2019
@wren wren added the 📌 This can't go stale label Sep 21, 2019
@dradux
Copy link

dradux commented Sep 23, 2019

This has been a blocker for me to use the app in any serious way for over 2 years. Perhaps I am not the target user but search seems to be the cornerstone to journals/notes (assuming you intend to use them in any meaningful way in the future). You will likely need to find something you wrote in the past and relying on adding a tag for everything you may want search on does not seem feasible. Do typical users fall back to grep for this or build their own lucene index?

@wren
Copy link
Member

wren commented Sep 25, 2019

@dradux You'll be happy to know that Search is one of our top priorities and now scheduled for an upcoming milestone.

I can't speak for most users (although I'd love to hear other people's approaches), but my personal approach is to open the whole journal in neovim when I want to do any searching of this kind. I do this because I keep most of my journals encrypted, so grep isn't super useful. I use ripgrep for the unencrypted journals sometimes. Either way, it'd be useful to have something built in for users.

As for building an index, the plain text format, and the encryption feature come together to make building and keeping any sort of metadata (including an index) very tricky in jrnl. I consider both of those features integral to jrnl, so metadata has been a difficult topic to approach, and search will likely depend on it in some way or another (unless we want to search the entire journal every time, which can lead to some performance problems in larger journals).

All of that is to say that we have a milestone to consider the exact format we want to use in jrnl going forward (which this will include considerations for metadata while maintaining the plain text and encryption features). This needs to happen before we implement a feature like search, but both are definitely in the pipeline.

@empireshades
Copy link

any update on this one?

@pspeter
Copy link
Contributor

pspeter commented Nov 12, 2019

Nobody has submitted a PR yet. It is scheduled for a future release already, but there's some other issues/features that were prioritized. You are welcome to submit a PR if you want to have this feature in sooner.

@empireshades
Copy link

empireshades commented Nov 12, 2019

I just submitted #740. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 📌 This can't go stale
Projects
None yet
Development

No branches or pull requests

8 participants