Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CAG): added back missing CAG.fromCompactBinary #91

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

kaosat-dev
Copy link
Contributor

@kaosat-dev kaosat-dev commented Jan 28, 2018

This PR fixes a MAJOR regression introduced in the last release that broke CAG.fromCompactBinary

* added correct exports
* upgrading tests so this does not happen again
* added clearTags helper to be able to compare objects while disregarding
(irrelevant tags)
@z3dev
Copy link
Member

z3dev commented Jan 29, 2018

Cool.
So, were the test cases correct?

@kaosat-dev
Copy link
Contributor Author

@z3dev they were disabled as the object 'tags' were causing issues, but I added a simpler helper to sort that side out, and they worked fine :)

@kaosat-dev kaosat-dev merged commit 57e8f5d into master Jan 29, 2018
@kaosat-dev kaosat-dev deleted the fix-compactBinary branch February 24, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants