-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yielding the hdrhistogram crate name #1
Comments
Hi - I have no problem w this in principle. Let me look at the details. |
OK, so it looks like this hdrhistogram has a non-zero number of users, so it should still be available. I think we rename the crate to hdrhistogram_c in crates.io and put a note in the README for the Rust hdrhistogram so they can easily update their Cargo.toml. |
Huh interesting... Those may just be bot downloads. But yes, we should be on the safe side, so that seems like a reasonable course of action! The way to go about it would then likely be:
How does that sound? /cc @marshallpierce |
@jsgf ping just to keep this on your radar. |
@jsgf still okay with going ahead with this? |
I'm doing the update at the moment. I guess you won't be able to recycle any of the old version numbers, so if you start at >=0.2 then existing users with Cargo.lock files will build unmodified, but new users will need to switch to hdrhistogram_c to continue using the API; otherwise they can convert to the hdrhistogram API. |
Yup, the intention was to continue |
I'm the maintainer of the hdrsample crate, a pure-Rust implementation of HdrHistogram. It's pretty close to feature complete now, and Gil Tene (@giltene; the original HdrHistogram author) wants to move it into the official HdrHistogram GitHub organization (HdrHistogram/HdrHistogram_rust#60).
When doing so, we'd also like to rename the crate to hdrhistogram to maintain consistency with the various other HdrHistogram implementations. However, that name is already taken by this crate. Given that it seems to no longer be maintained, we've been wondering whether we could convince you to give up the hdrhistogram crate name so we could replace it with the now-official Rust crate?
If you decide that's okay, you unfortunately can't currently delete or rename crates on crates.io (rust-lang/crates.io#166), but we should be able to just replace the crate in-place with the Rust version if you add me using
cargo owner
: http://doc.crates.io/crates-io.html#cargo-ownerLet me know what you think!
Cheers,
Jon
The text was updated successfully, but these errors were encountered: